Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show submenus on click #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hoogkamer
Copy link
Contributor

Hi,

I use the submenu function which is great. But as I use 2 levels, I experience the 'hover tunnel' challenge.
https://uxmovement.com/navigation/why-hover-menus-do-users-more-harm-than-good/

To solve that, I added the option to choose for clicks (or you can still use hover) to open submenus.

this.addEventListener('mousedown', this.mouseEnterHandler);
} else {
this.addEventListener('mouseenter', this.mouseEnterHandler);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got an extra newline here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, removed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants