New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing problem with rating change not being equal #2

Open

wakeless wants to merge 1 commit into iain:master from wakeless:equal-change

wakeless commented Apr 10, 2012

There's a problem with matches where they don't necessarily have the same change (with 2 players the same rating)

This breaks other specs though and I'm not sure how the expectations were generated.


          Fixing problem with rating change not being equal

c67559e

hellola commented Jun 9, 2017

This is actually a considerable problem as:

x = Elo::Player.new
y = Elo::Player.new

500.times do
  x.wins_from(y)
  y.wins_from(x)
end

puts x.rating
puts y.rating

results in around 500 for each whereas with this fix its 994 and 1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet