Skip to content

Commit

Permalink
Aligned PHPStan baseline and updated Symfony deprecations helper sett…
Browse files Browse the repository at this point in the history
…ing (#426)

For more details see #426

Key changes:

* Fixed PHPStan issue

* [Tests] Increased max deprecation number after Symfony release

---------

Co-authored-by: Andrew Longosz <[email protected]>
  • Loading branch information
mikadamczyk and alongosz authored Sep 16, 2024
1 parent 6759bf7 commit b9f1582
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion phpstan-baseline-gte-8.0.neon
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ parameters:
path: src/bundle/Core/Imagine/IORepositoryResolver.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\URLChecker\\\\Handler\\\\HTTPHandler\\:\\:createCurlHandlerForUrl\\(\\) should return resource but returns CurlHandle\\.$#"
message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\URLChecker\\\\Handler\\\\HTTPHandler\\:\\:createCurlHandlerForUrl\\(\\) should return resource but returns \\(CurlHandle\\|false\\)\\.$#"
count: 1
path: src/bundle/Core/URLChecker/Handler/HTTPHandler.php

Expand Down
15 changes: 0 additions & 15 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -9675,11 +9675,6 @@ parameters:
count: 2
path: src/lib/FieldType/Keyword/KeywordStorage/Gateway/DoctrineStorage.php

-
message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
count: 1
path: src/lib/FieldType/Keyword/KeywordStorage/Gateway/DoctrineStorage.php

-
message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\\\Gateway\\\\DoctrineStorage\\:\\:assignKeywords\\(\\) has parameter \\$keywordMap with no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -10275,11 +10270,6 @@ parameters:
count: 3
path: src/lib/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php

-
message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
count: 1
path: src/lib/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php

-
message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\\\Gateway\\\\DoctrineStorage\\:\\:getIdUrlMap\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -16430,11 +16420,6 @@ parameters:
count: 12
path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

-
message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
count: 1
path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

-
message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Gateway\\\\DoctrineDatabase\\:\\:addSort\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
>
<php>
<ini name="error_reporting" value="-1" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=576&amp;verbose=0"/>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=631&amp;verbose=0"/>
</php>
<testsuites>
<testsuite name="unit_core">
Expand Down

0 comments on commit b9f1582

Please sign in to comment.