IBX-8356: Removed Ibexa\Core\MVC\Symfony\Security\Authentication\AuthenticatorInterface to be replaced with Symfony-based authentication

[konradoboza]

🎫 Issue	IBX-8356

Description:

Should be tested together with:
ibexa/recipes-dev#124
ibexa/graphql#67

Mentioned interface relies on deprecated security concepts ergo can be safely removed. The only places where it's built upon is JWT for REST and GraphQL. Since both of those authentication mechanisms were reworked, we can proceed with ibexa/core changes.

Besides simple removal of the interface I added src/lib/MVC/Symfony/Security/Authentication/EventSubscriber/OnAuthenticationTokenCreatedRepositoryUserSubscriber.php which strips redundancy whenever we need to have repository user set (stateless calls validating JWT for GraphQL, JWT for REST, RestAuthenticator and coming from ibexa/core - DefaultSuccessHandler).

TODO:

• provide subscriber unit test.

For QA:

Sanities are basically all we need to track down potential usages I might be missing at this point.

Documentation:

Removal of AuthenticatorInterface should be mentioned in the doc.

[alongosz]

I'm assuming this can be merged after or with merging ibexa/rest#98, but there are also usages:

• https://github.com/ibexa/graphql/blob/ea8ff6d/src/lib/Mutation/Authentication.php#L11
• https://github.com/ibexa/rest/blob/ibx-8290-re-implement-rest-auth/src/lib/Server/Controller/JWT.php#L12 (seems not to be covered by IBX-8290: Reworked REST authentication to comply with the new Symfony authenticator mechanism under separate firewall rest#98).

[konradoboza]

I'm assuming this can be merged after or with merging

@alongosz have you heard what they say about assuming? 😉

This PR is a next step of our authentication-switch journey which is about re-assessing and reworking all the code relying on the mentioned interface (see attached ticket). I opened this PR just to check if ibexa/core has any more usages that I missed and see if CI here needs any further adjustments. I am perfectly aware of the other repositories that are still in use of AuthenticatorInterface...

I am a bit surprised you already reviewed this one - marking it as work in progress to avoid more premature reviews.

[konradoboza]

Note to myself: this interface needs to be marked as deprecated in 4.6.
#387

[adamwojs]

Please remember to cover this change in upgrade guide.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud