Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Configured generic reactor workflow #380

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jun 10, 2024

🎫 Issue n/a
Target 4.6+

Description:

This PR configures generic reactor workflow. The aim here is to avoid repeating GHA configuration across dozens of maintained repositories. Instead we want to have one place to rule them all.

Known issues

Not related to the idea of this workflow, but just to the linter itself:

I already see that we're going to have an issue with Symfony flavor of Yaml:

(node:1750) [TAG_RESOLVE_FAILED] YAMLWarning: Unresolved tag: !php/const at line 4, column 42:

    ibexa.core.io.flysystem.write_flags: !php/const LOCK_EX
(...)
(node:1750) [TAG_RESOLVE_FAILED] YAMLWarning: Unresolved tag: !tagged at line 20, column 39:

            $versionTargetEvaluators: !tagged ibexa.permissions.limitation_type…
                                      ^^^^^^^

!php/const, !tagged, !tagged_iterator, and more like that are valid expressions for Yaml interpreted by Symfony. I'm not sure if we can configure linter to take this into account.

Documentation:

Internal tool already internally documentent.

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alongosz alongosz requested review from adamwojs, ibexa-yuna and a team June 10, 2024 11:24
@alongosz alongosz added the Feature New feature request label Jun 10, 2024
@alongosz
Copy link
Member Author

@ibexa-yuna I've tried to add generic reactor workflow to core. It works, but the linter itself generates warnings (see the job output and PR description).

@ibexa-yuna
Copy link
Contributor

@ibexa-yuna I've tried to add generic reactor workflow to core. It works, but the linter itself generates warnings (see the job output and PR description).

I think this is OKay and we just need to change the action in the reactee workflow

@alongosz
Copy link
Member Author

Status: Before we merge this one, I was tasked to explore in more details what else we can add here (code style, tests). Almost all pieces are in place for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants