IBX-8418: Remove draft when trashing its parent or ancestor location #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
force-pushed
the
ibx-8418-deleting-orphaned-drafts
branch
from
a70054e
to
964cd70
Compare
barw4
force-pushed
the
ibx-8418-deleting-orphaned-drafts
branch
from
964cd70
to
d737438
Compare
alongosz
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Ok, so I was thinking about something completely different during internal sync.
It's possible to create content items without Locations. Maybe in case of removal of a Location, just node assignment should be removed, keeping drafts "dangling"? These drafts should still be visible on Drafts view.
Just an idea. // POV ping @ibexa/php-dev
|
@alongosz That's a cool idea, however, I think there are too many problems with drafts without node assignment. We cannot publish them using UI and I assume some other things will fail for them as well. |
barw4
force-pushed
the
ibx-8418-deleting-orphaned-drafts
branch
from
f2e6dd0
to
f80cb5c
Compare
barw4
changed the title
adamwojs
approved these changes
Jul 9, 2024
Steveb-p
reviewed
Aug 2, 2024
src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
| { | ||
| $subLocations = $this->locationGateway->getChildren($locationId); | ||
| foreach ($subLocations as $subLocation) { | ||
| $this->deleteChildrenDrafts($subLocation['node_id']); |
There was a problem hiding this comment.
A recursive call? Won't this be a massive performance penalty for deep trees?
There was a problem hiding this comment.
Few lines above we have the same situation and it was there for ages 🤷🏻 : https://github.com/ibexa/core/blob/main/src/lib/Persistence/Legacy/Content/TreeHandler.php#L196
Removing it in a single query may not be easy as this table is tree-like with the only information being of a record's parent.
alongosz
reviewed
Aug 5, 2024
konradoboza
reviewed
Aug 7, 2024
konradoboza
approved these changes
Aug 7, 2024
For more details see #406 Key changes: * Extracted common base for TextBlock and TextLine field types * [Tests] Aligned tests with TextBlock and TextLine changes * [Tests] Reduced complexity of TextBlock and TextLine test classes * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Paweł Niedzielski <[email protected]>
For more details see #407 Key changes: * Extracted redundant Binary and Media SearchField into a common base * [Tests] Extracted common base for Binary and Media ft integration tests * [Tests] Made MediaIntegrationTest::getValidFieldSettings return type more strict * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Mikolaj Adamczyk <[email protected]>
For more details see #424 Key changes: * Extracted abstract `AffixBasedTextMatcher` for redundant Host & URI text matchers * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Konrad Oboza <[email protected]>
…425) For more details see #425 Key changes: * Refactored Float and Integer field types to use external validators * [Tests] Refactored Float, Integer, and String validator tests --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Paweł Niedzielski <[email protected]>
For more details see https://issues.ibexa.co/browse/IBX-8138 and #385 Key changes: * [Rector] Applied Symfony 5.1 CommandConstantReturnCodeRector * [Rector] Applied Symfony 5.2 RenameMethodRector * [Rector] Applied Symfony 5.3 Rector sets * [Rector] Applied Symfony code quality Rector sets Applied rules: * LiteralGetToRequestClassConstantRector * ResponseStatusCodeRector * MakeCommandLazyRector * [Rector] Applied Return type rectors Applied rules: * ReturnTypeFromStrictNativeCallRector * ReturnTypeFromStrictScalarReturnExprRector * [Rector] Applied Symfony 6.0 AddReturnTypeDeclarationRector * [Rector] Added Symfony Bundle::getContainerExtension return type * Added strict types for InstallPlatformCommand consts * Made XML serialization exception more verbose in Author and DateTime converters * Implemented `\Ibexa\Core\MVC\Symfony\Security\User::getUserIdentifier` --------- Co-Authored-By: Paweł Niedzielski <[email protected]> Co-Authored-By: Konrad Oboza <[email protected]>
) For more details see #427 Key changes: * Fixed strict types for URLChecker HTTPHandler::createCurlHandlerForUrl * Introduced strict getters for URL ValueObject * Improved LogicException message * [PHPStan] Aligned baseline with the changes
barw4
force-pushed
the
ibx-8418-deleting-orphaned-drafts
branch
from
0352c82
to
9c886eb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/admin-ui#1321
https://github.com/ibexa/content-tree/pull/85
Description:
Currently, drafts without a location (so not yet published) that are orphaned due to missing ancestor location are forever stuck in the void. They cause multiple issues in different parts of DXP and they are not easily removable.
This PR makes sure that every time a location is trashed drafts under this given location or its child locations are removed.
Documentation:
Probably required