Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8811: Rebranded SiteAccess session prefix #420

Merged
merged 1 commit into from
Oct 2, 2024
Merged

IBX-8811: Rebranded SiteAccess session prefix #420

merged 1 commit into from
Oct 2, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Aug 22, 2024 •
edited
Loading

🎫 Issue IBX-8811

Description:

While checking if session sharing between SiteAccesses works (it does 😄) in the new security ecosystem I decided to improve code quality a little and rebrand eZSESSID to IBX_SESSION_ID as it is one of the leftovers that we have after the rebranding process. Remarks related to the naming are welcome.

For QA:

Documentation:

@konradoboza konradoboza marked this pull request as ready for review August 23, 2024 09:36
@konradoboza konradoboza requested a review from a team August 23, 2024 09:39
@Steveb-p Steveb-p requested a review from a team August 23, 2024 09:42
@konradoboza konradoboza added the Doc needed The changes require some documentation label Aug 23, 2024
alongosz
alongosz approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongosz alongosz requested a review from a team August 23, 2024 10:54
This was referenced Aug 28, 2024
Merged
Merged
@alongosz alongosz force-pushed the ibx-8811-SA-sessions-sharing branch 2 times, most recently from cae3f56 to 341e79a Compare September 17, 2024 09:25
@katarzynazawada katarzynazawada mentioned this pull request Sep 17, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza merged commit 9328655 into main Oct 2, 2024
13 checks passed
@konradoboza konradoboza deleted the ibx-8811-SA-sessions-sharing branch October 2, 2024 11:02
barw4 pushed a commit that referenced this pull request Oct 17, 2024
@konradoboza @barw4
IBX-8811: Rebranded SiteAccess session prefix (#420)
72754be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @Steveb-p @alongosz @ciastektk @katarzynazawada @mikadamczyk @tischsoic