IBX-8897: Fixed incorrect extrapolation of parentheses in the name schema pattern #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alongosz
reviewed
Nov 12, 2024
Comment on lines
+254
to
+257
| // Skip the group if it has no fields to parse | ||
| if (!preg_match('/<.*>/', $group)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
After looking into this we could probably do more complex regex in L248:
// match groups "( )" containing fields "< >" - curly brackets without any fields are not a group, but a literal string
$foundGroups = preg_match_all('/\((.*<.+>.*)\)/U', $nameSchema, $groupArray);But as we discussed internally, I'm not sure which solution would be better for @ibexa/php-dev. The current one is maybe more readable.
POV ping @ibexa/php-dev
alongosz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing the regression introduced in #242. Right now, for example, if we us this name schema
<title|(<field1> - <field2>)> (foobar)the foobar would be parsed to(EZMETAGROUP_0)regardless of the previously parsed fields. Grouping functionality with()has no use if the content inside this group has no<fields>.