Skip to content

Commit

Permalink
Some extra cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
ViniTou committed Oct 21, 2024
1 parent f1738c8 commit f4bd44b
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 15 deletions.
2 changes: 1 addition & 1 deletion doc/domain_schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Another, `AddDomainContentToDomainGroup`, will add the same Domain Content to it

### Custom Field Types

Fields values are handled by the `AddFieldValueToDomainContent` content domain schema worker. It uses Field Value Builders (instances of `Schema\Domain\Content\FieldValueBuilder\FieldValueBuilder`) to generate the type and resolution for each field.
Fields values are handled by the `AddFieldValueToItem` content domain schema worker. It uses Field Value Builders (instances of `Schema\Domain\Content\FieldValueBuilder\FieldValueBuilder`) to generate the type and resolution for each field.

Basic field types are handled by the `BaseFieldValueBuilder`. It maps each fieldtype, using its identifier, to either a type, or a type and a resolver. For the time being, it can not be customized.

Expand Down
2 changes: 1 addition & 1 deletion doc/howto/custom_field_type.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class RelationFieldDefinitionMapper extends DecoratingFieldDefinitionMapper impl

if (count($settings['selectionContentTypes']) === 1) {
$contentType = $this->contentTypeService->loadContentTypeByIdentifier($settings['selectionContentTypes'][0]);
$type = $this->nameHelper->domainContentName($contentType);
$type = $this->nameHelper->itemName($contentType);
} else {
$type = 'DomainContent';
}
Expand Down
2 changes: 0 additions & 2 deletions src/bundle/Resources/config/services/resolvers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ services:
Ibexa\GraphQL\Resolver\DomainContentResolver:
tags:
- { name: overblog_graphql.resolver, alias: "DomainContentItemsByTypeIdentifier", method: "resolveDomainContentItems" }
- { name: overblog_graphql.resolver, alias: "DomainFieldValue", method: "resolveDomainFieldValue" }
- { name: overblog_graphql.resolver, alias: "DomainContentType", method: "resolveDomainContentType" }
- { name: overblog_graphql.resolver, alias: "DomainContentItem", method: "resolveDomainContentItem" }
- { name: overblog_graphql.resolver, alias: "DomainRelationFieldValue", method: "resolveDomainRelationFieldValue" }
Expand Down Expand Up @@ -118,7 +117,6 @@ services:
tags:
- { name: overblog_graphql.resolver, alias: "SearchContent", method: "searchContent" }
- { name: overblog_graphql.resolver, alias: "SearchContentOfTypeAsConnection", method: "searchContentOfTypeAsConnection" }
- { name: overblog_graphql.resolver, alias: "SearchLocationsOfTypeAsConnection", method: "searchLocationsOfTypeAsConnection" }
arguments:
$searchService: '@ibexa.siteaccessaware.service.search'

Expand Down
4 changes: 0 additions & 4 deletions src/bundle/Resources/config/services/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ services:
arguments:
$innerMapper: '@Ibexa\GraphQL\Schema\Domain\Content\Mapper\FieldDefinition\SelectionFieldDefinitionMapper.inner'

Ibexa\GraphQL\Schema\Domain\Content\Worker\FieldDefinition\AddFieldValueToDomainContent: ~

Ibexa\GraphQL\Schema\Domain\Content\Worker\ContentType\AddItemOfTypeConnectionToGroup: ~

Ibexa\GraphQL\Schema\Domain\Content\Worker\ContentType\AddItemToGroup: ~
Expand Down Expand Up @@ -100,8 +98,6 @@ services:

Ibexa\GraphQL\Schema\Generator: ~

Ibexa\GraphQL\Schema\ImagesVariationsBuilder: ~

Ibexa\GraphQL\Schema\SchemaGenerator: ~

Ibexa\GraphQL\Schema\Domain\Pluralizer: ~
Expand Down
8 changes: 1 addition & 7 deletions src/lib/Resolver/SearchResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
*/
class SearchResolver
{
/**
* @var \Ibexa\Contracts\Core\Repository\SearchService
*/
private $searchService;

/**
* @var \Ibexa\GraphQL\InputMapper\SearchQueryMapper
*/
Expand All @@ -32,10 +27,9 @@ class SearchResolver
*/
private $contentLoader;

public function __construct(ContentLoader $contentLoader, SearchService $searchService, SearchQueryMapper $queryMapper)
public function __construct(ContentLoader $contentLoader, SearchQueryMapper $queryMapper)
{
$this->contentLoader = $contentLoader;
$this->searchService = $searchService;
$this->queryMapper = $queryMapper;
}

Expand Down

0 comments on commit f4bd44b

Please sign in to comment.