Allowed payload to be replaced in EndpointRequestDefinition #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5
This PR allows payload to be replaced when creating
EndpointRequestDefinition
s in a data provider.First of all, it introduces the
withPayload
method, which returns a clone of a request definition with changed payload.Second, payload name is now always set by the factory. This prevents an issue where - since name is used as data provider dataset key - changing the request payload caused data provider to contain multiple entries under the same key, resulting in PHPUnit error.
Checklist:
@ibexa/engineering
).