Upstream merge 2023-07-10 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joel Lappalainen <[email protected]>
…_client Refactor HTTP client
…ll-distance Fix fare leg rule mapper, introduce builder
…/graphql-16.x Update dependency graphql to v16.7.1
…/com.google.cloud-libraries-bom-26.x Update dependency com.google.cloud:libraries-bom to v26.18.0
…/major-graphqlcodegenerator-monorepo Update graphqlcodegenerator monorepo (major)
…ctance Add escalator reluctance parameter
miles-grant-ibigroup
requested changes
Jul 10, 2023
|
There is a smoke test for Denver and Seattle which checks the vehicle positions and they can be successfully fetched. Why do you think it's no longer valid? |
|
Seeing this:
|
|
What is the router-config in question? The following works for the smoke test: https://github.com/opentripplanner/OpenTripPlanner/blob/efb34f22dd0d2b955dc2c9c0f2b5ad1926cee101/smoke-tests/denver/router-config.json#L1-L0 |
|
Is it possible that you've deployed a very old version? I cannot find the error string in the current version and OTPMain.java:55 is not a line that logs anything. |
miles-grant-ibigroup
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge doesn't contain anything immediately relevant for IBI but there are a number of larger refactorings that I want to run through the smoke test pipeline to check if everything still works.