Custom ec2 ami, instance type and region

[evansiroky]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

There currently isn't an issue for this, but here is what this PR does:

• allows customizing an ec2 deployment in the following ways:
  • setting a custom AMI ID for graph builds only
  • setting a custom instance type for graph builds only
  • setting a custom region for the deployment
• modifies the DeployJob to be able to do the following
  • do graph building with a separate instance type and/or AMI ID (this could be a substitute resolution for Subsequent EC2 instance for ELB deployments wait until first server has loaded graph before starting #265).
  • upload a graph build report if one was generated
• modifies other controllers to support custom regions
• Adds better debug information to deploy log statements
• skips request/response logging for job statuses

[codecov-io]

Codecov Report

Merging #282 into dev will increase coverage by 0.06%.
The diff coverage is 1.41%.

@@            Coverage Diff             @@
##              dev     #282      +/-   ##
==========================================
+ Coverage      20%   20.06%   +0.06%     
- Complexity    407      423      +16     
==========================================
  Files         151      151              
  Lines        8219     8398     +179     
  Branches     1111     1163      +52     
==========================================
+ Hits         1644     1685      +41     
- Misses       6430     6565     +135     
- Partials      145      148       +3

Flag	Coverage Δ	Complexity Δ
#unit_tests	20.06% <1.41%> (+0.06%)	423 <0> (+16)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...m/conveyal/datatools/manager/models/OtpServer.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ools/manager/controllers/api/ServerController.java	4.95% <0%> (-0.45%)	1 <0> (ø)
...com/conveyal/datatools/manager/models/EC2Info.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...com/conveyal/datatools/manager/jobs/DeployJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...datatools/manager/jobs/MonitorServerStatusJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../manager/controllers/api/DeploymentController.java	8.07% <0%> (-0.23%)	2 <0> (ø)
.../com/conveyal/datatools/common/utils/AWSUtils.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...om/conveyal/datatools/common/utils/SparkUtils.java	42.97% <0%> (-0.36%)	17 <0> (ø)
.../conveyal/datatools/manager/models/Deployment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...nveyal/datatools/common/status/MonitorableJob.java	74.57% <66.66%> (-0.21%)	11 <0> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423ed4d...3d77359. Read the comment docs.

[binh-dam-ibigroup]

Minor cosmetic changes.

[landonreed]

Just a few minor comments (mainly about comments). Looks great otherwise!

[evansiroky]

See latest changes.

[landonreed]

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀