Support copy from right in timetable editor #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
assigned josh-willis-arcadis and unassigned daniel-heppner-ibigroup
josh-willis-arcadis
approved these changes
May 20, 2024
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
binh-dam-ibigroup
requested changes
Sep 24, 2024
| case 76: { // l | ||
| // Set current cell's value to adjacent cell's (rightward) value. | ||
| const adjacentCol = columns[this._getColIndex(scrollToColumn) + 1] | ||
| if (evt.shiftKey && !activeCell && isTimeFormat(adjacentCol.type)) { |
There was a problem hiding this comment.
Need to check that adjacentCol is defined (see console error), and that check needs to be added for copy-from-left.
There was a problem hiding this comment.
I think there should also be an isTimeFormat check for the focused cell. (We probably don't want to copy a time value into a non-time cell, but this is possible, as written, from the first time cell into the trip short name cell).
There was a problem hiding this comment.
There is a caveat that the adjacent cells must be visible for the copy operations to complete, but that is not blocking for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Timetable editor has a cool keyboard shortcut to copy from left/top, but nothing to copy from right! We add shift+l to do this, mirroring shift+'.
Please test thoroughly I could only come up with so many edge cases. Tempted to add a new e2e case