Add Checkbox question type #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amy-corson-ibigroup
approved these changes
Oct 11, 2024
miles-grant-ibigroup
force-pushed
the
checkboxes
branch
from
1f185b7 to
e530269
Compare
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
requested changes
Oct 15, 2024
| }, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [selectedOptions] | ||
| ) |
There was a problem hiding this comment.
Don't use useEffect here. Just make a callback function that calls updateSelectedOptions and updateCallback and call that function from line 35 where you call updateSelectedOptions now
| [selectedOptions] | ||
| ) | ||
|
|
||
| const uuid = v4() |
There was a problem hiding this comment.
hmmm. Does this cause the id to change on every rerender? Like when a box is checked and unchecked?
| type="checkbox" | ||
| value={index} | ||
| /> | ||
| <span className={styles.label} id={`${option}-label`}> |
There was a problem hiding this comment.
If you are using option for the ID here then why not use it for the key on label too instead of index?
| className={styles.button} | ||
| defaultChecked={selectedOptions[index] === true} | ||
| disabled={disabled} | ||
| id={`${uuid}-${index}`} |
There was a problem hiding this comment.
why not just use option or option-index?
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
Putting this on hold for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious for feedback on styling. Tried to optimize for longer answer lengths.