refactor(compiler): fix Compiler.dialect type hint, remove unneeded…

… `duckdb` compilation rule for `RegexReplace` (#10400)
ibis-project · Oct 31, 2024 · a806691 · a806691
1 parent 210ab3c
commit a806691
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/ibis/backends/sql/compilers/base.py b/ibis/backends/sql/compilers/base.py
@@ -522,7 +522,7 @@ def impl(self, op, *, left, right):
 
     @property
     @abc.abstractmethod
-    def dialect(self) -> str:
+    def dialect(self) -> type[sg.Dialect]:
         """Backend dialect."""
 
     @property

diff --git a/ibis/backends/sql/compilers/duckdb.py b/ibis/backends/sql/compilers/duckdb.py
@@ -523,9 +523,6 @@ def visit_TimestampNow(self, op):
         """DuckDB current timestamp defaults to timestamp + tz."""
         return self.cast(super().visit_TimestampNow(op), dt.timestamp)
 
-    def visit_RegexReplace(self, op, *, arg, pattern, replacement):
-        return self.f.regexp_replace(arg, pattern, replacement, "g")
-
     def visit_First(self, op, *, arg, where, order_by, include_null):
         if not include_null:
             cond = arg.is_(sg.not_(NULL, copy=False))