Skip to content

Commit

Permalink
test(backends): remove now unused supports_floating_modulus backend…
Browse files Browse the repository at this point in the history
… flag (#8939)

Test case configuration now happens through pytest markers.

depends on #8937

---------

Co-authored-by: Gil Forsyth <[email protected]>
  • Loading branch information
kszucs and gforsyth authored Apr 11, 2024
1 parent a19bb00 commit ede3a83
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion docs/contribute/05_reference.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ from ibis.backends.tests.base import BackendTest
class TestConf(BackendTest):
"""Backend-specific class with information for testing."""

supports_floating_modulus = False
returned_timestamp_unit = "us"
supports_structs = True
supports_json = True
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/bigquery/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
class TestConf(BackendTest):
"""Backend-specific class with information for testing."""

supports_floating_modulus = False
returned_timestamp_unit = "us"
supports_structs = True
supports_json = True
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/clickhouse/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class TestConf(ServiceBackendTest):
check_dtype = False
returned_timestamp_unit = "s"
supported_to_timestamp_units = {"s"}
supports_floating_modulus = False
supports_json = False
force_sort = True
rounding_method = "half_to_even"
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/exasol/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class TestConf(ServiceBackendTest):
supports_arrays = False
returned_timestamp_unit = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
supports_floating_modulus = True
native_bool = True
supports_structs = False
supports_json = False
Expand Down
2 changes: 0 additions & 2 deletions ibis/backends/tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ class BackendTest(abc.ABC):
"Whether backend supports Arrays / Lists"
returned_timestamp_unit: str = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
supports_floating_modulus: bool = True
"Whether backend supports floating point in modulus operations"
native_bool: bool = True
"Whether backend has native boolean types"
supports_structs: bool = True
Expand Down

0 comments on commit ede3a83

Please sign in to comment.