depr(api): deprecate filtering/expression projection in Table.__getitem__
#10073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
commented
Sep 9, 2024
| "deprecated and will be removed in version 10.0. Please use " | ||
| "`Table.select` or `Table.filter` instead.", | ||
| FutureWarning, | ||
| ) |
There was a problem hiding this comment.
The only relevant code is here, everything else is swapping table[...] for either select or filter in the tests or docs.
jcrist
force-pushed
the
depr-magic-getitem
branch
2 times, most recently
from
0d7ccf2
to
6059eae
Compare
jcrist
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
jcrist
force-pushed
the
depr-magic-getitem
branch
from
6059eae
to
0729cc4
Compare
jcrist
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates filtering and expression projection in
Table.__getitem__. See the relevant issue (#10045) for reasoning.Currently the warning says we'll remove in 10.0 - if we think that's too short a deprecation period I'm happy to bump to 11.0.
The magic syntax is old and was used in quite a few places in the test suite and docs. I think I got most of them, but won't be surprised if this PR fails CI initially due to a few lingering references.
Fixes #10045.