Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pandas): remove the pandas backend #10112

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 13, 2024

Remove the pandas backend.

BREAKING CHANGE: The pandas backend is removed. Note that pandas DataFrames are STILL VALID INPUTS AND OUTPUTS and will remain so for the foreseeable future. Please use one of the other local backends like DuckDB, Polars, or DataFusion to perform operations directly on pandas DataFrames.

@cpcloud cpcloud added this to the 10.0 milestone Sep 13, 2024
@cpcloud cpcloud added pandas The pandas backend breaking change Changes that introduce an API break at any level labels Sep 13, 2024
@cpcloud cpcloud force-pushed the remove-pandas-backend branch 2 times, most recently from 5fc33a0 to f72d6fe Compare September 13, 2024 14:16
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will need a rebase to clean up my mess.

@cpcloud cpcloud force-pushed the remove-pandas-backend branch 2 times, most recently from fdb2529 to 8f3b25e Compare September 13, 2024 15:54
@cpcloud
Copy link
Member Author

cpcloud commented Sep 13, 2024

Probably a good idea to remove the Pandas backend CI jobs!

BREAKING CHANGE: The `pandas` backend is removed. Note that **pandas DataFrames are STILL VALID INPUTS AND OUTPUTS** and will remain so for the foreseeable future. Please use one of the other local backends like DuckDB, Polars, or DataFusion to perform operations directly on pandas DataFrames.
@gforsyth
Copy link
Member

Probably a good idea to remove the Pandas backend CI jobs!

Reasonable people can differ

Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Sep 13, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Sep 13, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Sep 13, 2024

Just being safe and making sure the blast radius here doesn't somehow break the ☁️s

@cpcloud cpcloud merged commit d4e8c11 into ibis-project:main Sep 13, 2024
94 checks passed
@cpcloud cpcloud deleted the remove-pandas-backend branch September 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that introduce an API break at any level pandas The pandas backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants