Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repr): remove expression printing from exception message #10130

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 14, 2024

There is some deeper work in this area to audit the places where we are doing this and 1) remove it and possibly 2) figure out a way to turn off interactive mode whenever an Ibis exception is raised. Closes #10124.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis ux User experience related issues labels Sep 14, 2024
@cpcloud cpcloud force-pushed the remove-expr-repr-from-exception branch 2 times, most recently from 7544600 to 0e45d4d Compare September 14, 2024 15:07
@cpcloud cpcloud force-pushed the remove-expr-repr-from-exception branch from 0e45d4d to ec3c727 Compare September 14, 2024 15:14
@gforsyth
Copy link
Member

xref #10092 which is re: removing repr-ing from SignatureValidationError

@cpcloud
Copy link
Member Author

cpcloud commented Sep 15, 2024

Clouds are passing the new test.

ibis/backends/tests/test_interactive.py::test_no_recursion_error[snowflake] PASSED [ 50%]
ibis/backends/tests/test_interactive.py::test_no_recursion_error[bigquery] PASSED [100%]

@cpcloud cpcloud merged commit 8a260a8 into ibis-project:main Sep 15, 2024
75 checks passed
@cpcloud cpcloud deleted the remove-expr-repr-from-exception branch September 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: maximum recursion error when adding count values from different filters
2 participants