-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(polars): allow user to specify "engine" kwarg #10151
feat(polars): allow user to specify "engine" kwarg #10151
Conversation
We don't have tests for streaming, but we have a blog post that uses it, so it has had coverage. It would be good to verify this behavior does something in the test suite. It can be a smoke test. |
Maybe to avoid requiring a GPU for support we could do a mocktest just to ensure we're plumbing the |
Yeah, using |
Yep, sounds good, I was planning to mock it (and maybe actually go ahead and do the same for making sure |
Co-authored-by: Jim Crist-Harif <[email protected]>
Co-authored-by: Phillip Cloud <[email protected]> Co-authored-by: Jim Crist-Harif <[email protected]>
Description of changes
Modeled after support for "streaming" kwarg, but I have a couple questions: