Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigquery): ensure that quoting test generates unique table name #10182

Merged
merged 1 commit into from
Sep 20, 2024
Merged

test(bigquery): ensure that quoting test generates unique table name #10182

merged 1 commit into from
Sep 20, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 20, 2024

Fixes upstream failing test due to name clashes.

@cpcloud cpcloud added this to the 10.0 milestone Sep 20, 2024
@cpcloud cpcloud added the bigquery The BigQuery backend label Sep 20, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Sep 20, 2024

Passing locally:

ibis/backends/bigquery/tests/system/test_connect.py::test_create_table_from_memtable_needs_quotes PASSED [100%]

Going to merge to get main back to green.

@cpcloud cpcloud merged commit 4050073 into ibis-project:main Sep 20, 2024
75 checks passed
@cpcloud cpcloud deleted the region-table-fix branch September 20, 2024 10:43
@cpcloud cpcloud added the tests Issues or PRs related to tests label Sep 20, 2024
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
@cpcloud @ncclementi
test(bigquery): ensure that quoting test generates unique table name (i…
7c6a176 
…bis-project#10182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bigquery The BigQuery backend tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud