-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: several Table.sample
improvements
#10207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Issues or PRs related to tests
polars
The polars backend
labels
Sep 24, 2024
jcrist
force-pushed
the
improve-sample
branch
from
September 24, 2024 16:41
abb4c85
to
f32bcd3
Compare
how for Polars? my understanding is lazyframes still don't support for posterity see #10207 (comment) |
jcrist
commented
Sep 24, 2024
cpcloud
reviewed
Sep 24, 2024
…e` to native `TABLESAMPLE` syntax when possible
jcrist
force-pushed
the
improve-sample
branch
from
September 24, 2024 19:15
f32bcd3
to
eb218fc
Compare
cpcloud
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
sample
forpolars
risingwave
/druid
to be compile time rather than execution timeTable.sample
to the backend's nativeTABLESAMPLE
clause when possible forbigquery
,postgres
,mssql
,oracle
, andimpala
. This is much more efficient when usingmethod="block"
as it lets the backend avoid reading in whole blocks of data, dramatically reducing IO. This was the main goal of this PR.