Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add get_backend to expr #10228

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(api): add get_backend to expr #10228

merged 1 commit into from
Sep 27, 2024

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Sep 25, 2024

@github-actions github-actions bot added the tests Issues or PRs related to tests label Sep 25, 2024
@cpcloud
Copy link
Member

cpcloud commented Sep 27, 2024

@mesejo Is this ready for review?

@cpcloud cpcloud added the feature Features or general enhancements label Sep 27, 2024
@mesejo
Copy link
Contributor Author

mesejo commented Sep 27, 2024

@mesejo Is this ready for review?

Yes, I think it is.

@mesejo mesejo marked this pull request as ready for review September 27, 2024 13:10
cpcloud
cpcloud approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , would you mind undrafting the PR?

@cpcloud cpcloud added this to the 10.0 milestone Sep 27, 2024
@cpcloud cpcloud enabled auto-merge (squash) September 27, 2024 13:19
@cpcloud cpcloud changed the title feat: add get_backend to expr feat(api): add get_backend to expr Sep 27, 2024
@cpcloud cpcloud changed the title feat(api): add get_backend to expr feat(api): add get_backend to expr Sep 27, 2024
@cpcloud cpcloud merged commit 4b34a61 into ibis-project:main Sep 27, 2024
79 checks passed
@lostmygithubaccount
Copy link
Member

thanks @mesejo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

feat: <expression>.get_backend()
3 participants
@mesejo @cpcloud @lostmygithubaccount