Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sql): clean up unnecessary use of explicit visit methods #10419

Merged
merged 2 commits into from
Nov 3, 2024
Merged

refactor(sql): clean up unnecessary use of explicit visit methods #10419

merged 2 commits into from
Nov 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 2, 2024

No description provided.

@cpcloud cpcloud added this to the 10.0 milestone Nov 2, 2024
@github-actions github-actions bot added bigquery The BigQuery backend sql Backends that generate SQL labels Nov 2, 2024
@gforsyth gforsyth added impala The Apache Impala backend postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend pyspark The Apache PySpark backend datafusion The Apache DataFusion backend duckdb The DuckDB backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend oracle The Oracle backend labels Nov 2, 2024
@gforsyth gforsyth added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Nov 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Nov 2, 2024
@cpcloud cpcloud merged commit dbde452 into ibis-project:main Nov 3, 2024
106 checks passed
@cpcloud cpcloud deleted the cleanup-unnecessary-visit-methods branch November 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
bigquery The BigQuery backend clickhouse The ClickHouse backend datafusion The Apache DataFusion backend duckdb The DuckDB backend impala The Apache Impala backend mssql The Microsoft SQL Server backend oracle The Oracle backend postgres The PostgreSQL backend pyspark The Apache PySpark backend snowflake The Snowflake backend sql Backends that generate SQL sqlite The SQLite backend trino The Trino backend
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth