Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): remove option_context #10438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 5, 2024

Removes code for contextually setting options that is only used in testing.

BREAKING CHANGE: option_context is removed. Use contextlib.contextmanager to create your own version of this functionality if necessary.

@cpcloud cpcloud added this to the 10.0 milestone Nov 5, 2024
@cpcloud cpcloud added ux User experience related issues breaking change Changes that introduce an API break at any level labels Nov 5, 2024
@github-actions github-actions bot added tests Issues or PRs related to tests impala The Apache Impala backend postgres The PostgreSQL backend clickhouse The ClickHouse backend labels Nov 5, 2024
BREAKING CHANGE: `option_context` is removed. Use `contextlib.contextmanager` to create your own version of this functionality if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that introduce an API break at any level clickhouse The ClickHouse backend impala The Apache Impala backend postgres The PostgreSQL backend tests Issues or PRs related to tests ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant