Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add null examples header and expected failure #10496

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

IndexSeek
Copy link
Member

Description of changes

Adds the section header for the examples for null.

I added the expected failure annotation, but the # quartodoc: +EXPECTED_FAILURE comment still shows up in the render.

image

I wasn't sure if there was something special I needed to do for it not to show up, like how this is here but the # doesn't show up in the pivot_longer examples.

>>> who.pivot_longer( # quartodoc: +EXPECTED_FAILURE
... s.index["new_sp_m014":"newrel_f65"],
... names_to=["diagnosis", "gender", "age"],
... names_pattern="new_?(.*)_.(.*)",
... )

image

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cpcloud cpcloud added this to the 10.0 milestone Nov 16, 2024
@cpcloud cpcloud added analytics Higher-level data analysis API related issues or PRs docs Documentation related issues or PRs and removed analytics Higher-level data analysis API related issues or PRs labels Nov 16, 2024
@cpcloud cpcloud merged commit b1be5ea into ibis-project:main Nov 16, 2024
80 checks passed
@IndexSeek IndexSeek deleted the fix-null-example branch November 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants