-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contribute): include instructions to use Pixi #10504
Open
deepyaman
wants to merge
4
commits into
ibis-project:main
Choose a base branch
from
deepyaman:docs/contribute/pixi-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1022a89
docs(contribute): include instructions to use Pixi
deepyaman ad5f6c4
docs(contribute): dedent the callout to fix format
deepyaman 95e8c44
docs(contribute): give up on numbered list callout
deepyaman 3452844
docs(contribute): move note on Pixi init artifacts
deepyaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ the `conda/mamba` setup and refer to the comment related to `arm64` | |
architectures. | ||
::: | ||
|
||
## Conda/Mamba | ||
## Conda/Mamba/Pixi | ||
|
||
### Support matrix [^conda-callout] | ||
|
||
|
@@ -45,6 +45,10 @@ managers = { | |
"name": "Mamba", | ||
"url": "https://github.com/mamba-org/mamba", | ||
}, | ||
"pixi": { | ||
"name": "Pixi", | ||
"url": "https://pixi.sh/latest/", | ||
}, | ||
} | ||
|
||
for manager, params in managers.items(): | ||
|
@@ -58,7 +62,10 @@ for manager, params in managers.items(): | |
print(f"1. Install `gh`") | ||
print() | ||
print(" ```sh") | ||
print(f" {manager} install -c conda-forge gh") | ||
if manager == "conda" or manager == "mamba": | ||
print(f" {manager} install -c conda-forge gh") | ||
elif manager == "pixi": | ||
print(f" {manager} global install gh") | ||
print(" ```") | ||
print() | ||
print(f"1. Fork and clone the ibis repository:") | ||
|
@@ -67,37 +74,48 @@ for manager, params in managers.items(): | |
print(" gh repo fork --clone --remote ibis-project/ibis") | ||
print(" ```") | ||
print() | ||
print(f"1. Create a Conda environment using `environment.yml`") | ||
print(f"1. Create a {name} environment using `environment.yml`") | ||
print() | ||
print(" ```sh") | ||
print(" cd ibis") | ||
print(f" {manager} env create --file conda/environment.yml") | ||
if manager == "conda" or manager == "mamba": | ||
print(f" {manager} env create --file conda/environment.yml") | ||
elif manager == "pixi": | ||
print(f" {manager} init --import conda/environment.yml") | ||
print(" ```") | ||
print() | ||
if manager == "conda" or manager == "mamba": | ||
print() | ||
print( | ||
" If you're using arm64 architecture (Mac M1/M2), use " | ||
"`conda/environment-arm64.yml` for setting up a dev environment for all the " | ||
"backends that are possible to install excluding Flink; use " | ||
"`conda/environment-arm64-flink.yml` for setting up a dev environment for all " | ||
"the backends that are possible to install including Flink. The reason to have " | ||
"two separate environments is because `apache-flink` forces `pyarrow` to " | ||
"downgrade to 11.0, which causes conflicts in other backends." | ||
) | ||
print( | ||
" If you're using arm64 architecture (Mac M1/M2), use " | ||
"`conda/environment-arm64.yml` for setting up a dev environment for all the " | ||
"backends that are possible to install excluding Flink; use " | ||
"`conda/environment-arm64-flink.yml` for setting up a dev environment for all " | ||
"the backends that are possible to install including Flink. The reason to have " | ||
"two separate environments is because `apache-flink` forces `pyarrow` to " | ||
"downgrade to 11.0, which causes conflicts in other backends." | ||
) | ||
print() | ||
if manager == "pixi": | ||
print(" ::: {.callout-note}") | ||
print(" This command will initialize a `pixi.toml` file and also modify ") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, we could provide Pixi configuration in |
||
print(" the `.gitignore` to prevent Pixi configuration from being added to ") | ||
print(" `git`.") | ||
print(" :::") | ||
print() | ||
print(f"1. Activate the environment") | ||
print() | ||
print(" ```sh") | ||
print(f" {manager} activate ibis-dev") | ||
if manager == "conda" or manager == "mamba": | ||
print(f" {manager} activate ibis-dev") | ||
elif manager == "pixi": | ||
print(f" {manager} shell") | ||
print(" ```") | ||
print() | ||
print( | ||
f"1. Install your local copy of `ibis` into the {manager.capitalize()} environment" | ||
) | ||
print() | ||
print(" ```sh") | ||
print(" pip install -e .") | ||
print(" uv pip install -e .") | ||
print(" ```") | ||
print() | ||
``` | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do this because I don't use
gh
, but wanted to keep things consistent...