Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): treat integer inputs as literals instead of column references #8884

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Apr 3, 2024

Removing the int-as-column references in mutate and select. Further discussed in #8878.

BREAKING CHANGE: Integer inputs to select and mutate are now always interpreted as literals. Columns can still be accessed by their integer index using square-bracket syntax.

@kszucs kszucs marked this pull request as ready for review April 8, 2024 10:09
@kszucs kszucs requested a review from cpcloud April 9, 2024 08:27
@cpcloud cpcloud added this to the 9.0 milestone Apr 12, 2024
@kszucs kszucs force-pushed the int_as_column branch 2 times, most recently from 05ac8c4 to 02a7718 Compare April 12, 2024 14:30
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase breaking change Changes that introduce an API break at any level labels Apr 13, 2024
@cpcloud cpcloud merged commit feeb8ae into ibis-project:main Apr 13, 2024
90 checks passed
@cpcloud cpcloud deleted the int_as_column branch April 13, 2024 14:38
cpcloud pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that introduce an API break at any level refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants