-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BASE_DOCKER_REGISTRY_CREDENTIAL_ID for external-test #185
Conversation
LongyuZhang
commented
Oct 30, 2023
- BASE_DOCKER_REGISTRY_CREDENTIAL_ID is needed to increase daily image pull limit when running container-based external testing
- Related Issue: runtimes/backlog/issues/1234
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
@AdamBrousseau Could you review it? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think if you add the dockerCredential
lines to the specs you are running External tests then this PR should be fine.
- BASE_DOCKER_REGISTRY_CREDENTIAL_ID is needed to increase daily image pull limit when running container-based testing Signed-off-by: LongyuZhang <[email protected]>
|
@@ -523,6 +527,7 @@ class Build { | |||
context.booleanParam(name: 'DYNAMIC_COMPILE', value: DYNAMIC_COMPILE), | |||
context.string(name: 'DOCKER_REGISTRY_URL', value: DOCKER_REGISTRY_URL), | |||
context.string(name: 'DOCKER_REGISTRY_URL_CREDENTIAL_ID', value: DOCKER_REGISTRY_URL_CREDENTIAL_ID), | |||
context.string(name: 'BASE_DOCKER_REGISTRY_URL_CREDENTIAL_ID', value: BASE_DOCKER_REGISTRY_URL_CREDENTIAL_ID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_DOCKER_REGISTRY_CREDENTIAL_ID
is set above, but we are using BASE_DOCKER_REGISTRY_URL_CREDENTIAL_ID
here (which is not being defined)