Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OpenJCEPlus Branch to the build scripts #223

Merged
merged 1 commit into from
May 14, 2024

Conversation

AdamBrousseau
Copy link

Also add ability to override openjceplus branch at build launch

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Also add ability to override openjceplus branch at build launch

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau
Copy link
Author

Test cases

00:00:21.655      "PUBLISH_NAME": "jdk-11.0.23.1.2+9_openj9-0.44.0-rc2",
...
00:00:46.663  WARNING: OpenJCEPlus Branch cannot be determined based on PUBLISH_NAME. Using default branch: semeru-java11
00:01:02.701      "PUBLISH_NAME": "jdk-11.0.23+9_openj9-0.44.0-rc2",
...
00:01:27.776  BUILD_CONFIG[OPENJCEPLUS_BRANCH]="semeru-java-11.0.23"
00:00:19.644      "PUBLISH_NAME": "jdk-11+9_openj9-0.44.0-rc2",
...
00:00:43.651  BUILD_CONFIG[OPENJCEPLUS_BRANCH]="semeru-java-11"
00:00:15.454      "PUBLISH_NAME": "jdk-11.0.23.1+9_openj9-0.44.0-rc2",
...
00:00:40.814  BUILD_CONFIG[OPENJCEPLUS_BRANCH]="semeru-java-11.0.23.1"

@AdamBrousseau AdamBrousseau merged commit d93795c into ibmruntimes:ibm May 14, 2024
2 checks passed
AdamBrousseau added a commit to AdamBrousseau/openjdk-build that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant