issue_9128 solves issue working with non-default docker registries #230
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
while working with non-default docker registery, the local image tag will be DOCKER_REGISTRY+DOCKER_IMAGE. This change will add a tag with DOCKER_IMAGE only then the rest of pipeline witch works with DOCKER_IMAGE will not fail. Also it improves fetching .RepoDigests so do not need `dockerImageDigest = dockerImageDigest.replaceAll("\\[", "").replaceAll("\\]", "")` anymore
Signed-off-by: [email protected]
Signed-off-by: Mahdi Ardekanian <[email protected]>
while working with non-default docker registry, the local image tag will be DOCKER_REGISTRY+DOCKER_IMAGE. This change will add a tag with DOCKER_IMAGE only then the rest of pipeline witch works with DOCKER_IMAGE will not fail. Also it improves fetching .RepoDigests so do not need
dockerImageDigest = dockerImageDigest.replaceAll("\\[", "").replaceAll("\\]", "")anymoreSigned-off-by: [email protected]