Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preservePosition option to DragMarker #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

invpt
Copy link

@invpt invpt commented Sep 13, 2022

Would resolve #21. I realized that this option would be super easy to implement without losing any of the flexibility offered by allowing users to pass through a Key.

Let me know if you prefer a different name than preservePosition. Also not sure if the && !isDragging is necessary.

@ibrierley
Copy link
Owner

Thanks for this, it sounds good initially and preservePosition sounds fine.

I had played with using keys last weekend hoping to simplify things, but kept hitting problems when integrating with another plugin that swaps orders of dragMarkers, but maybe I can hack something with onPanUpdate there.

Thanks again, it may be a few days before I get chance to test properly.

@ibrierley
Copy link
Owner

Thanks for this, I think this looks good. I think there's a weird bug with web, where markers can vanish oddly (if they scroll the edge of the screen). However, I'm pretty sure this isn't related to your PR at all, but I may try and see if I can figure what's causing it before merging.

@ytneu
Copy link

ytneu commented May 27, 2024

Hi guys, any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatically update the location of a marker that already exists
3 participants