#130: don't include disallow null if it's not true

icapps · Sep 11, 2023 · 4cdc535 · 4cdc535
1 parent 102ccbd
commit 4cdc535
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/example/lib/model/user/project/project.dart b/example/lib/model/user/project/project.dart
diff --git a/lib/writer/object_model_writer.dart b/lib/writer/object_model_writer.dart
@@ -104,7 +104,10 @@ class ObjectModelWriter {
       sb.write("  @JsonKey(name: '${key.serializedName}'");
       if (key.isRequired) {
         if (key.hasDefaultValue) {
-          sb.write(', required: false, disallowNullValue: ${key.disallowNull}');
+          sb.write(', required: false');
+          if (key.disallowNull) {
+            sb.write(', disallowNullValue: ${key.disallowNull}');
+          }
         } else {
           sb.write(', required: true');
         }

diff --git a/test/writer/object_model_writer/default-field-required/output.txt b/test/writer/object_model_writer/default-field-required/output.txt
@@ -7,7 +7,7 @@ part 'person.g.dart';
 @JsonSerializable(explicitToJson: true)
 class Person {
   ///A good description
-  @JsonKey(name: 'firstName', required: false, disallowNullValue: false)
+  @JsonKey(name: 'firstName', required: false)
   final String firstName;
 
   const Person({