Skip to content

Commit

Permalink
icecream: Fix POSIX header paths
Browse files Browse the repository at this point in the history
The sys/{fcntl,poll,signal}.h paths are historic and should not be used,
except perhaps in pre-POSIX.1-2001 systems.
  • Loading branch information
ismaell committed Aug 19, 2024
1 parent 9d397ef commit c1afc05
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ AM_CONDITIONAL([WITH_ICECREAM_MAN], [test "x$build_man" != "xno"])

# Some of these are needed by popt (or other libraries included in the future).

AC_CHECK_HEADERS([sys/signal.h ifaddrs.h kinfo.h sys/param.h devstat.h])
AC_CHECK_HEADERS([signal.h ifaddrs.h kinfo.h sys/param.h devstat.h])
AC_CHECK_HEADERS([sys/socketvar.h sys/vfs.h])
AC_CHECK_HEADERS([mach/host_info.h])
AC_CHECK_HEADERS([arpa/nameser.h], [], [],
Expand Down
6 changes: 3 additions & 3 deletions daemon/serve.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/wait.h>
#ifdef HAVE_SYS_SIGNAL_H
# include <sys/signal.h>
#endif /* HAVE_SYS_SIGNAL_H */
#ifdef HAVE_SIGNAL_H
# include <signal.h>
#endif /* HAVE_SIGNAL_H */
#include <sys/param.h>
#include <unistd.h>

Expand Down
2 changes: 1 addition & 1 deletion daemon/workit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include <sys/time.h>
#include <sys/types.h>
#include <unistd.h>
#include <sys/fcntl.h>
#include <fcntl.h>
#include <sys/wait.h>
#include <signal.h>
#include <sys/resource.h>
Expand Down
2 changes: 1 addition & 1 deletion scheduler/scheduler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include <netinet/in.h>
#include <arpa/inet.h>
#include <poll.h>
#include <sys/signal.h>
#include <signal.h>
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
Expand Down
2 changes: 1 addition & 1 deletion services/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#define ICECREAM_UTIL_H

#include <string>
#include <sys/poll.h>
#include <poll.h>
#include <vector>
#include <unistd.h>

Expand Down

0 comments on commit c1afc05

Please sign in to comment.