-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message Data Serialization [minor] #271
Open
ric-evans
wants to merge
82
commits into
main
Choose a base branch
from
solidify-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ric-evans
changed the title
Make Test Data Absolutely Static
Message Data Serialization [minor]
Sep 20, 2024
ric-evans
force-pushed
the
solidify-tests
branch
from
September 24, 2024 19:52
dfbd95c
to
f3e2173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON objects/files will now be used during message I/0. This change will ease the transition to SkyDriver 2.0 (EWMS 1.0).
This change can be seen in the following sections:
skymap_scanner/skymap_scanner/server/start_scan.py
Lines 402 to 409 in 0d3aeb0
skymap_scanner/skymap_scanner/client/reco_icetray.py
Lines 278 to 283 in 0d3aeb0
skymap_scanner/skymap_scanner/client/reco_icetray.py
Lines 180 to 189 in 0d3aeb0
skymap_scanner/skymap_scanner/server/start_scan.py
Lines 475 to 479 in 0d3aeb0
Testing
The test data format for the single-pixel tests is now unified, so no script is needed to pre-transform data--this follows general best practices for testing.