-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a brief mention to QUEST in icepyx docs intro. #514
Conversation
👈 Launch a binder notebook on this branch for commit e3e5a08 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 92da5c7 👈 Launch a binder notebook on this branch for commit a2cb65d 👈 Launch a binder notebook on this branch for commit 5785c47 👈 Launch a binder notebook on this branch for commit 3e0dd97 👈 Launch a binder notebook on this branch for commit c5e0cb9 👈 Launch a binder notebook on this branch for commit 91f7f8f 👈 Launch a binder notebook on this branch for commit 5f74220 👈 Launch a binder notebook on this branch for commit 7700c22 👈 Launch a binder notebook on this branch for commit 60a04f6 👈 Launch a binder notebook on this branch for commit e18386d 👈 Launch a binder notebook on this branch for commit 1b2f563 👈 Launch a binder notebook on this branch for commit f0387f5 👈 Launch a binder notebook on this branch for commit 8eef12d 👈 Launch a binder notebook on this branch for commit f18e35b 👈 Launch a binder notebook on this branch for commit 1c87139 👈 Launch a binder notebook on this branch for commit 539f1ad |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #514 +/- ##
============================================
Coverage 66.19% 66.19%
============================================
Files 36 36
Lines 3065 3065
Branches 541 541
============================================
Hits 2029 2029
Misses 945 945
Partials 91 91 ☔ View full report in Codecov by Sentry. |
Add mention to Github readme, and add a link to the QUEST example to Github readme. |
Agreed - perhaps even as simple as a "(via the QUEST module)" annotation where we're noting "relevant ancillary datasets" in the first paragraph?
Would we like to encourage users to cite QUEST specifically within their icepyx citation? This could also be a good opportunity to add the link to citing ArgoVis on our citations page. EDIT: Citation for ArgoVis and more info on citing Argo data here, in the "Identification of Data Sources" section after the team photos. Ultimately, we'll want to add some language in the contributing section (probably "Contributing Guidelines" for users adding a new dataset, but I think it would make the most sense to add that when we're also adding the "how to add a new dataset" guide. |
Will address suggestions next week, after ST meeting chaos is out of the way. |
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: Jessica Scheick <[email protected]>
So are we good to merge this with development? |
If you're good with the updated citation formatting! |
Addressing Task 3 in Issue #474.
Were there any other pages that we wanted to add mention of QUEST? I was thinking maybe the "Origin and Purpose" page, though it's also just a general overview icepyx's conception.