-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark tests which depend on ECS as expected fail; separate integration and unit tests #609
Conversation
👈 Launch a binder notebook on this branch for commit d917999 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 084ab7d 👈 Launch a binder notebook on this branch for commit 3430c89 👈 Launch a binder notebook on this branch for commit b773376 👈 Launch a binder notebook on this branch for commit 25346ea |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #609 +/- ##
===============================================
+ Coverage 65.47% 66.68% +1.21%
===============================================
Files 38 36 -2
Lines 3134 3077 -57
Branches 601 594 -7
===============================================
Hits 2052 2052
+ Misses 991 935 -56
+ Partials 91 90 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the init.py and conftest.py files remain at the icepyx/tests directory level? Otherwise the integration tests won't pick up the auth info from conftest.
Yes, excellent catch, thank you! I thought I had the |
Integration tests run: https://github.com/icesat2py/icepyx/actions/runs/11040360996/job/30668167255 The tests marked |
No description provided.