Data Dictionary V1.23

[lindaxiang]

Update:

1. Added two optional fields in radiation schema to denote radiation boost
2. Allow negative interval in specimen to ingest the data from Monstar

Both dictionary changes have been tested successfully in QA.

[justincorrigible]

Looks good, left a couple suggestions and a question, that all can be ignored.

[justincorrigible]

Will there ever be a case when treatment ID is "unknown" or other generic values? if so, is that valid?

[lindaxiang]

@justincorrigible you pointed out a valid use case. However based on the current validation rule, if indicating radiation_boost as yes while treatment ID is "Unknown", the program will need to apply exception on field reference_radiation_treatment_id.

[justincorrigible]

Sounds like something to be addressed in a different PR.
This one is good to go 👍

[lindaxiang]

If you are DCC admin, you can use the following test files to test the dictionary updates:
QA platform: https://platform-ui.argo-qa.cumulus.genomeinformatics.org/
program: MONSTAR-JP
clinical files:

1. specimen has negative intervals - specimen_v1.23.txt
2. treatment - treatment_v1.23.txt
3. radiation has two optional fields to denote radiation boost for one donor - radiation_dictionary_v1.23.txt

[justincorrigible]

Ship it!