Fixes for Quest Accounts Panel showing Desktop version #575
Conversation
|
I am hoping this fixes the two reported issues although it's still not logging into Google. I think that's because builds from PRs don't have access to secrets and logcat seems to show a failure with oAuth so it's at least attempting to make the request. One issue seems to stem back to the i18n work - some of the prefab overrides on the PopUpWindow_Accounts_Mobile had been lost so it was behaving like PopUpWindow_Accounts The other issue was related to the Labs panel although @mikeskydev reported that it didn't open for him - for me the issue was that I got the desktop version rather than the mobile version. I've rewritten some of the panel opening logic which had got a bit murky. |
|
This PR was built from a branch, so it has the secrets. Only PRs from forks (e.g.,the IxxyXR repo) don't have access to the secrets. |
hmmmm. in which case i'll need to dig deeper. |
|
I'm a bit stuck here. Just tested #548 which was the PR merged directly before #549 - and the problem is still there. So it wasn't #549 I found an discrepancy relating to changes made in the i18n merge but that didn't fix it. Still looking but if you get a chance to look, let me know if you have any ideas. I guess a manual bisect might be the next thing. |
|
Previous comment was meant for @mikeskydev ... |
|
@andybak Yeah, it shows one of the option windows when it shouldn't right? that's fine, just the error I was seeing when testing was that clicking 'sign in' prompted to remove headset. if it's back to the other bug, that's fine, i'll tackle that seperately! |
|
I just compared to pre 1.0 and there were a few differences in which game objects were visible initially. I've pushed a change that fixes this |
|
Authentication appears to be a different issue, so i'm happy for this to be merged in the meantime |
No description provided.