Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zapbox: Set to iPhone only for now #638

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Zapbox: Set to iPhone only for now #638

merged 1 commit into from
Mar 1, 2024

Conversation

mikeskydev
Copy link
Member

Will need changing when we deploy ARKit based app.

Will need changing when we deploy ARKit based app.
@mikeskydev mikeskydev requested a review from mikeage March 1, 2024 10:30
@mikeskydev mikeskydev added the bugfix Something has been fixed label Mar 1, 2024
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have a bunch of places that assume iPhone == Zapbox, but that's fine; we'll revisit it if / when we do ARKit. Shouldn't be too bad

@andybak
Copy link
Contributor

andybak commented Mar 1, 2024

we'll revisit it if / when we do ARKit.

I'd like to ship view-only mode before that. All that needs is an iOS build that doesn't show an error screen if the Zapbox isn't detected.

@mikeage
Copy link
Member

mikeage commented Mar 1, 2024

we'll revisit it if / when we do ARKit.

I'd like to ship view-only mode before that. All that needs is an iOS build that doesn't show an error screen if the Zapbox isn't detected.

Even better! I assume two separate releases would be probably be more user friendly, but we have the infra to do this now

@mikeskydev
Copy link
Member Author

With the way zapbox works it's an all or nothing SDK, we'll either always have a separate build that loads zapbox, or somehow figure out a button to launch zapbox mode from the main build

@mikeskydev mikeskydev merged commit ee02891 into main Mar 1, 2024
40 checks passed
@mikeskydev mikeskydev deleted the fix/ios-targets branch March 1, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants