Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zapbox] Temp set portrait orientation #642

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

mikeskydev
Copy link
Member

@mikeskydev mikeskydev commented Mar 5, 2024

Zapbox requires portrait mode for rendering, but nothing else does. It's time for some temp setting variables in the build pipeline again!

New IDisposable for general player settings. I imagine we might use this again.

@mikeskydev mikeskydev added the bugfix Something has been fixed label Mar 5, 2024
@mikeage
Copy link
Member

mikeage commented Mar 5, 2024

@mikeage
Copy link
Member

mikeage commented Mar 5, 2024

(other than that, looks good)

@mikeskydev
Copy link
Member Author

My bad, not installed pre-commit since wiping computer!

@mikeskydev mikeskydev marked this pull request as ready for review March 5, 2024 14:48
@mikeskydev mikeskydev merged commit 44000fd into main Mar 5, 2024
40 checks passed
@mikeskydev mikeskydev deleted the fix/zappar-orientation branch March 5, 2024 16:51
@@ -9,7 +9,7 @@ PlayerSettings:
AndroidFilterTouchesWhenObscured: 0
AndroidEnableSustainedPerformanceMode: 0
defaultScreenOrientation: 3
targetDevice: 0
targetDevice: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you just do this a few PRs ago? How will Apple not complain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants