ungrouping objects in glTF models #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick initial fix; Not ready for merge yet This fixes one major issue with the feature. Previously, you couldn't break apart a GLTF model more than once, as it would just create duplicates of the thing you were trying to break apart I don't know if the feature works for all cases of GLTF transform hierarchies
eeropomell
changed the title
Previously, the method continued iterating even after a valid children was found This simple change makes it stop as soon as the first valid child is found
andybak
merged commit 3c73383
into
icosa-foundation:feature/icosa-integration
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial fix; Not ready for merge yet. It hasn't been tested enough, so idk if it works for all kinds of GLTF transform hierarchies.
This fixes one major issue with the feature. Previously, you couldn't break apart a certain kind of GLTF model more than once, as it would just create duplicates of the thing you were trying to break apart.
Demo of breaking up GLTF model multiple times: https://youtu.be/Tb2jOGZF4fg