feat: hook up actions #127
Open
+1,186
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancfong
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Left a couple of comments - I think the most important thing is the one helper function being exported in a file with the "use server" directive which will still be callable by the client (think of it like creating another API route), so would be best to move that to another file without "use server"
| } | ||
| } | ||
|
|
||
| export async function _getMeetingDates( |
There was a problem hiding this comment.
move this function outside of the server action file, as this will otherwise also be exposed to be callable by the client
There was a problem hiding this comment.
maybe "cell" might be better name than "square"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
123for testing)