-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating UKIT009 #370
Updating UKIT009 #370
Conversation
I don't know if it is the cause of the CI failure, but I'm using a link whose target is not already present in the documentation (i.e. I wrote that in iKin the new iCub version will be available since release v2024.11.0 with the reference to the markdown that not exist yet). When I do |
I removed the reference to the page that doesn't exist yet and I will add that once we have the release v2024.11.0 |
Thanks heaps for the contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (5)
- docs/upgrade_kits/head_4k/support.md: Evaluated as low risk
- mkdocs.yml: Evaluated as low risk
- docs/icub_versions/index.md: Evaluated as low risk
- docs/icub_operating_systems/icubos/jetpack.md: Evaluated as low risk
- docs/icub_operating_systems/icubos/install-cmake.md: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done so far but I reckon we have to streamline a bit this PR, especially in terms of number of pages for the post-flashing procedure.
Also, we have to fix these warnings:
INFO - The following pages exist in the docs directory, but are not included in the "nav" configuration:
- icub_operating_systems/icubos/create-backup-image.md
INFO - Doc file 'icub_operating_systems/icubos/create-backup-image.md' contains a link '#jetpack-setup-on-the-host', but there is no such anchor on this page.
INFO - Doc file 'icub_operating_systems/icubos/create-backup-image.md' contains a link '#booting-the-nvidia-jetson-board-in-recovery-mode', but there is no such anchor on this page.
Hi @pattacini, thanks for the review!
you're right, I kept this info since, if I remember well, the Xavier NX is Ubuntu 18.04 based yet. But this board will become outdated with the UKIT009 update, so we could think about removing it from the documentation and refactoring the CMake installation instructions depending on the OS version. About the number of pages for the post-flashing operations, instead, talking with @Nicogene we agreed that the |
Disagree with that 😉
Let's meet up for it. |
In 33e7dc7 I applied the suggested changes after the f2f chat we had yesterday (cc @Nicogene @pattacini). In particular, I:
|
I regenerated the pages if you want to see the output now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, consider these further notes.
Hi @pattacini, here 40ff57e you can find the changes you suggested. I added the CMake installation instructions again but for Ubuntu 20.04 since it is required for yarp v3.10.0 and we had to follow this procedure on the laptop of iCubGenova11 which has Ubuntu 20.04 yet (cc @Nicogene) Please, let me know if it's ok now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps!
Merging.
This PR contains:
post-flashing operations
after jetpack installation: now, this information is stored in the dedicated pages, so the Jetpack installation page is shorter and clearer nowWhat is missing:
I'll keep the PR in draft until the previous points are addressed.
For the time being, I generated the documentation on my fork to see the output:
cc @Nicogene @pattacini