Finish up a variety of modules' SQA missing items to be able to enforce checks #28464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_sqa_modules
branch
2 times, most recently
from
dccd10b
to
bc17213
Compare
GiudGiud
force-pushed
the
PR_sqa_modules
branch
3 times, most recently
from
88a8a42
to
fcdc505
Compare
|
Job Documentation on ec528c3 wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_sqa_modules
branch
from
fcdc505
to
883c23e
Compare
GiudGiud
requested review from
bwspenc,
dschwen,
jiangwen84,
hugary1995,
cpgr,
lindsayad and
recuero
as code owners
GiudGiud
requested review from
cticenhour
and removed request for
dschwen,
bwspenc,
cpgr,
lindsayad,
jiangwen84,
recuero and
hugary1995
|
Job Coverage on ec528c3 wanted to post the following: Framework coverageCoverage did not change Modules coveragePhase field
Solid mechanics
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
Remove duplicate requirements refs idaholab#15968
Reword some requirements for current standard refs idaholab#15968
GiudGiud
force-pushed
the
PR_sqa_modules
branch
from
883c23e
to
f432b5d
Compare
GiudGiud
force-pushed
the
PR_sqa_modules
branch
from
f432b5d
to
ec528c3
Compare
|
I can work on this review today a bit and hopefully finalize tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #15968
I noticed the number of SQA warnings was actually going up rather than down. Once the checks are enforced as errors and not warnings, this wont happen anymore.
This PR enforces: