Pass MooseApp pointer to NEML2 #28492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwen
requested review from
hugary1995
and removed request for
bwspenc and
jiangwen84
|
It looks like NEML2 currently has no method in the options object to check if an option exists. |
hugary1995
requested changes
Aug 29, 2024
Comment on lines
+47
to
+50
| neml2::Model & get_model_moose(const std::string & mname, | ||
| MooseBase * moose_base, | ||
| bool enable_ad = true, | ||
| bool force_create = true); |
There was a problem hiding this comment.
What's the reason for not directly passing a pointer to MooseApp?
dschwen
force-pushed
the
neml2_mooseapp_28486
branch
from
ebfb80d
to
53744f2
Compare
dschwen
force-pushed
the
neml2_mooseapp_28486
branch
from
a516f75
to
bd0c41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28486