Add a Physics for THM compressible Euler flow model #28528
Conversation
| [] | ||
|
|
||
| [pipe] | ||
| type = PhysicsFlowChannel |
There was a problem hiding this comment.
Is it possible to have physics = myflowphysics here?
There was a problem hiding this comment.
yes, I started differently but I ll correct course
| [inlet] | ||
| type = PhysicsInletMassFlowRateTemperature | ||
| input = 'pipe:in' | ||
| physics = 'all' |
There was a problem hiding this comment.
Can we get rid of this parameter? The BC component should be able to query the connected component.
| /** | ||
| * Sets up the single-phase flow equations using Euler's equations and a RDG discretization | ||
| */ | ||
| class THMWCNSFVFlowPhysics : public virtual ThermalHydraulicsFlowPhysics, public virtual WCNSFVFlowPhysics |
There was a problem hiding this comment.
This will need a test of course
There was a problem hiding this comment.
oh this is like super not ready. will do
There was a problem hiding this comment.
Yeah I realized that later in the review 😄
|
|
||
| // boundary flux user object | ||
| // we add them in addBCs for convenience | ||
| if (boundary_type == InletTypeEnum::MdotTemperature) |
There was a problem hiding this comment.
Would someone be able to add a new BC formulation in their application without modifying THM?
There was a problem hiding this comment.
yes, by using a XYZFlowChannel instead of the Physics one
or by creating a new physics
| } | ||
|
|
||
| void | ||
| THMVACESinglePhaseFlowPhysics::addInletBoundaries() |
There was a problem hiding this comment.
Do we need to distinguish inlet/outlet, or can we just have a generic addFlowBCs() or whatever?
There was a problem hiding this comment.
modeling after WCNSFV here. in wcnsfv we do need to distinguish
There was a problem hiding this comment.
Sometimes the distinction can be blurry, like with reversible, and then there are walls.
|
thanks for the early feedback! |
GiudGiud
force-pushed
the
PR_thm_phy
branch
from
3f64312
to
57ff902
Compare
…e both from THM & NS physics
Suppress boundary parameters
This is better, if someone adds addUO in the TH physics base class, it wont compile until they clear the non-trivial override
Rename channel test inputs for convenience We could make this more general, as in ICs for any variable
…table Maybe it s time we make BlockRestrictableDynamic
… a2) type terms as volumetric sources in 1D flow channels
GiudGiud
force-pushed
the
PR_thm_phy
branch
from
2492534
to
1823b09
Compare
I hope to figure out at least with VACE:
with FV
I ll remove the WCNSFV part from the PR and put it into another PR. I m just trying things here to make sure the design will suit our needs