Makefile fix for external FP submodule inclusion

[GiudGiud]

refs #27027

[loganharbour]

Added install targets.

[GiudGiud]

ugh commit 2 fixes something but breaks another.
I ll leave only commit 1 for now

[moosebuild]

Job Documentation on cff8a9c wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage on cff8a9c wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Fluid properties

	b9e8bd	#28609 cff8a9
	Total	Total	+/-	New
Rate	85.19%	85.18%	-0.01%	-
Hits	7770	7769	-1	0
Misses	1351	1352	+1	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[loganharbour]

I think we probably need a sanity check from a few for this one

[GiudGiud]

This does not solve the header symlink warnings btw (which are caused by SodiumRevision.h being created in every module when building combined, for some reason)

But it should solve the missing "SinglePhaseFluidProperties.h" include when building the modules inside combined apps we have seen in the apptainer recipes

[loganharbour]

Looks like this breaks things: https://civet.inl.gov/job/2442762/

[GiudGiud]

Seems to be tied to the revision, the other problem. I invalidated to see if it gets it past

In file included from /data/civet1/build/blue_crab/build/unity_src/base_Unity.C:2:
/data/civet1/build/blue_crab/src/base/BlueCrabApp.C: In member function 'virtual std::string BlueCrabApp::header() const':
/data/civet1/build/blue_crab/src/base/BlueCrabApp.C:253:50: error: 'SODIUM_REVISION' was not declared in this scope; did you mean 'HELIUM_REVISION'?
  253 |   os << std::setw(25) << "  Sodium version: " << SODIUM_REVISION << "\n";
      |                                                  ^~~~~~~~~~~~~~~
      |                                                  HELIUM_REVISION
Compiling C++ (in opt mode) /data/civet1/build/blue_crab/build/unity_src/timesteppers_Unity.C...
Compiling C++ (in opt mode) /data/civet1/build/blue_crab/build/unity_src/postprocessors_Unity.C...
make: *** [/data/civet1/build/moose/framework/build.mk:150: /data/civet1/build/blue_crab/build/unity_src/base_Unity.x86_64-pc-linux-gnu.opt.lo] Error 1
make: *** Waiting for unfinished jobs....

ERROR: exiting with code 2

[GiudGiud]

Trying to fix the other issue too again

[GiudGiud]

Ok should be good.

The only fail is Okami, so I'll look to patch Okami most likely

[GiudGiud]

Okami patch is up https://hpcgitlab.hpc.inl.gov/idaholab/okami/-/merge_requests/42

this is good to go

[loganharbour]

moosebuild.hpc.inl.gov has been off for a while; need to get that back going

[milljm]

Its crazy how often I fix this, and then it breaks the following day

[milljm]

https://moosebuild.hpc.inl.gov is back online

[GiudGiud]

let's merge? stuff is failing downstream because this is not in
https://civet.inl.gov/job/2462068/

[GiudGiud]

Unrelated failure

[loganharbour]

Failure in https://civet.inl.gov/job/2445689/ was not unrelated