Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using field variables instead of scalar variables for THM junctions, part 3 #28658

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

joshuahansel
Copy link
Contributor

@joshuahansel joshuahansel commented Sep 18, 2024

Step 3 of #28514.

Refs #25593

This adds a new option "use_scalar_variables" to all volume-junction-based components, which is true by default but gives a deprecation message. The deprecation message points to a URL with relevant info on transitioning.

There were several re-golds, but none of them were from actually different results. They were all from:

New names for junction variables
New elements in the mesh (NodeElems)

@moosebuild
Copy link
Contributor

Job Precheck on 5a8c7af wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28658/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format a1cbad7e816d8f22f0cfbb2f392dcfd51e1d8f88

@joshuahansel joshuahansel force-pushed the junction-node-elem-step3 branch 2 times, most recently from 5bdb646 to 7f6f61a Compare September 18, 2024 22:16
@moosebuild
Copy link
Contributor

moosebuild commented Sep 19, 2024

Job Documentation on 4285a51 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on 4285a51 wanted to post the following:

Framework coverage

a1cbad #28658 4285a5
Total Total +/- New
Rate 85.04% 85.04% -0.00% 0.00%
Hits 105880 105880 - 0
Misses 18620 18622 +2 3

Diff coverage report

Full coverage report

Modules coverage

Thermal hydraulics

a1cbad #28658 4285a5
Total Total +/- New
Rate 88.45% 88.38% -0.07% 91.75%
Hits 13691 13794 +103 267
Misses 1787 1813 +26 24

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@joshuahansel
Copy link
Contributor Author

@loganharbour I added a function MooseUtils::mooseDocsURL(path) here for referring to a doc page in an error/warning message. Opinions on this? Maybe there should be a virtual method in the app, so that other apps can do a similar thing? With non-open apps, there are two URLs, one for binary and one for source. Maybe that can be some build preprocessor to flip those?

@joshuahansel
Copy link
Contributor Author

@lindsayad This is ready. The juicy bits are in VolumeJunction1Phase and ADVolumeJunctionBaseUserObject.

@joshuahansel joshuahansel removed the request for review from lindsayad September 25, 2024 20:31
@joshuahansel
Copy link
Contributor Author

@licharlot Can you review this when you get a chance? @lindsayad is on paternity leave now, so he no longer gets the great privilege.

@joshuahansel joshuahansel merged commit 0871cbc into idaholab:next Oct 1, 2024
50 checks passed
@joshuahansel joshuahansel deleted the junction-node-elem-step3 branch October 1, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants