-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using field variables instead of scalar variables for THM junctions, part 3 #28658
Using field variables instead of scalar variables for THM junctions, part 3 #28658
Conversation
Job Precheck on 5a8c7af wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
5bdb646
to
7f6f61a
Compare
Job Documentation on 4285a51 wanted to post the following: View the site here This comment will be updated on new commits. |
7f6f61a
to
346c6d1
Compare
Job Coverage on 4285a51 wanted to post the following: Framework coverage
Modules coverageThermal hydraulics
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
@loganharbour I added a function |
@lindsayad This is ready. The juicy bits are in |
@licharlot Can you review this when you get a chance? @lindsayad is on paternity leave now, so he no longer gets the great privilege. |
Step 3 of #28514.
Refs #25593
This adds a new option "use_scalar_variables" to all volume-junction-based components, which is true by default but gives a deprecation message. The deprecation message points to a URL with relevant info on transitioning.
There were several re-golds, but none of them were from actually different results. They were all from:
New names for junction variables
New elements in the mesh (NodeElems)