Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator of test vectors #100

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

OBrezhniev
Copy link
Member

@OBrezhniev OBrezhniev commented Aug 28, 2023

  • Fix generator of test vectors for contracts unit tests (missing IsRevocationChecked=1 flag in mtp).
  • Unification of sig & mtp test vector generators to minimize differences.
  • СircuitQueryHash - fix param name (first letter was cyrillic)
  • Unification of generateTestData & generateJSONLDTestData function signatures between sig & mtp.
  • Diff in testvectorgen/credentials/onchain/*/testdata/ is only in position of isRevocationChecked flag in input&output json.

Newly generated test vectors are already used here: iden3/contracts#173

Base automatically changed from feature/anonymous-components to develop August 29, 2023 17:23
…ocationChecked=1 flag in mtp). Unification of sig & mtp test vector generators to minimize differences.
@OBrezhniev OBrezhniev force-pushed the feature/fix-testvector-generatos branch from 34daaac to b87a3d9 Compare August 29, 2023 18:26
@OBrezhniev OBrezhniev merged commit 6303e06 into develop Sep 9, 2023
2 checks passed
@OBrezhniev OBrezhniev deleted the feature/fix-testvector-generatos branch September 9, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants